Skip to content

Conversation

@pascalecu
Copy link
Contributor

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed Modify Perl Testing #4881
  • I did not include any extra folders/libraries
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

I am making this edit to the testinfo.yml because Perl 5.28 is almost 7 years old already, with active support ending 5 years ago. It is officially EOL. So, it is better to track the stable-slim. New releases happen approximately twice per year, and Perl is known for being backwards compatible, so there should be no problems with existing tests (all current 131 tests pass with 5.42 which is the current stable-slim).

I was supposed to make this PR 3 months ago, however I forgot. 😅

Not exactly how to name the PR to make this work...

@pascalecu
Copy link
Contributor Author

Huh, it seems the check marks were happy, good to know.

@rzuckerm rzuckerm added enhancement Any code that improves the repo hacktoberfest Hacktoberfest related tests Testing related labels Oct 13, 2025
Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locking to a version that floats means that this could break in the future. It looks like the latest version is 5.43-slim. I'd prefer that that be used instead

@pascalecu
Copy link
Contributor Author

You don't want that, because odd versions are development releases. But sure, I can change it.

@pascalecu pascalecu requested a review from rzuckerm October 13, 2025 20:13
Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping this updated, @pascalecu !

@rzuckerm rzuckerm merged commit 2ca52f0 into TheRenegadeCoder:main Oct 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Any code that improves the repo hacktoberfest Hacktoberfest related tests Testing related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify Perl Testing

2 participants