Modify Java tests#5498
Merged
rzuckerm merged 1 commit intoTheRenegadeCoder:mainfrom Apr 10, 2026
Merged
Conversation
github-actions
Bot
added
enhancement
pascalecu
added a commit
to pascalecu/sample-programs
that referenced
this pull request
Apr 10, 2026
Even though Java 23 *does* support implicitly declared classes (it was the first version to introduce them), the image doesn't support them as they're supposedly a preview feature, so I could either wait for TheRenegadeCoder#5498 to get passed, or I could just do it the old way.
rzuckerm
approved these changes
Apr 10, 2026
pascalecu
added a commit
to pascalecu/sample-programs
that referenced
this pull request
Apr 10, 2026
Even though Java 23 *does* support implicitly declared classes (it was the first version to introduce them), the image doesn't support them as they're supposedly a preview feature, so I could either wait for TheRenegadeCoder#5498 to get passed, or I could just do it the old way.
pascalecu
added a commit
to pascalecu/sample-programs
that referenced
this pull request
Apr 10, 2026
Even though Java 23 *does* support implicitly declared classes (it was the first version to introduce them), the image doesn't support them as they're supposedly a preview feature, so I could either wait for TheRenegadeCoder#5498 to get passed, or I could just do it the old way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.
Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation
I Am Modifying an Existing Code Snippet or Existing Tests
Modify {PROJECT} {tests} in {LANGUAGE}formatOther Notes
It is wiser to pin the container on the latest LTS, which is JDK 25 right now. I would've switched to JDK 26 as it released a month ago, but I don't want to change the image every 6 months.