fix: parse tool-call arguments shell-style, not by naive whitespace split - #1
Merged
Merged
Conversation
…plit Reported: /bash command="find a b c d" kept the literal quote characters and dropped everything after the first word, and /bash command=find a b c (no quotes) dropped "a b c" entirely instead of treating them as part of the value. Root cause: argument tokens came from strings.Fields, which has no concept of quoting and splits purely on whitespace. Fix: - Tokenize with github.com/google/shlex instead, so a quoted value keeps internal spaces as one token with the quotes stripped. Malformed/ unterminated quoting falls back to plain content rather than erroring. - parseArguments now appends any word that is not itself a "key=value" for a declared property onto the previous key's value instead of dropping it, so an unquoted multi-word value is preserved too. A value that itself needs literal quotes (e.g. a shell command like find -name "test*") needs the outer key= value wrapped in the other quote style, or backslash-escaped - same as a real shell. Documented in the README and covered by new tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported:
/bash command="find a b c d"kept the literal quote characters and dropped everything after the first word;/bash command=find a b c(no quotes) droppeda b centirely instead of treating them as part of the value.Root cause: argument tokens came from
strings.Fields, which has no concept of quoting and splits purely on whitespace.Fix:
github.com/google/shlexinstead, so a quoted value keeps internal spaces as one token with the quotes stripped. Malformed/unterminated quoting falls back to plain content rather than erroring.parseArgumentsnow appends any word that isn't itself akey=valuefor a declared property onto the previous key's value instead of dropping it, so an unquoted multi-word value is preserved too.A value that itself needs literal quotes (e.g. a shell command like
find -name "test*") needs the outer value wrapped in the other quote style, or backslash-escaped - same as a real shell. Documented in the README, covered by new tests.