fix(shadow): Fix initial shadow states of draw modules #1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyaero42
reviewed
Sep 19, 2025
Skyaero42
approved these changes
Sep 19, 2025
xezon
force-pushed
the
xezon/fix-drawable-shadows-2
branch
from
8169fe5 to
c06d7a1
Compare
Author
|
Replicated in Generals without meaningful conflicts. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the initial shadow states of draw modules.
the model shadows in drawables are not correctly initialized: Even if a Drawable, such as the build placement preview object, is created without shadows, it will draw shadows.
The constructor of
W3DModelDrawsetsm_shadowEnabled = TRUEand ignores theDRAWABLE_STATUS_SHADOWSof the owning Drawable object. Pretty much all objects got initialized without shadows, but have shadows enabled on the first update during game start.Accordingly, I streamlined the implementation and made the shadow initialization consistent. Drawables no longer start with visible shadows when not given the
DRAWABLE_STATUS_SHADOWSflag on construction.User facing nothing should change.
TODO