unify(common): Move DamageFX, Dict, DiscreteCircle, Language, MessageStream... to Core

[Jaredl-Dev]

This moves nine Common header/source pairs shared by Generals and Zero Hour into Core:

• DamageFX
• Dict
• DiscreteCircle
• Language
• MessageStream
• MiniLog
• PerfTimer
• TerrainTypes
• version

The files are code-identical between both games. Seventeen files differ only in the product-name banner inside the opening license comment.

Verification

• Verified identical complete normalized source for all 18 files
• cmake --workflow --preset vc6
• cmake --workflow --preset win32

[greptile-apps]

Greptile Summary

The PR consolidates nine code-identical Common header/source pairs into Core so Generals and Zero Hour compile one shared source set.

• Enables all nine pairs in the Core GameEngine source list.
• Removes the duplicate pairs from both product-specific GameEngine source lists and trees.
• Records the completed moves in scripts/cpp/unify_move_files.py.
• Preserves compilation under each product target through the existing Core INTERFACE source target.

Confidence Score: 5/5

The PR appears safe to merge with no concrete build, runtime, or compatibility defects identified.

The moved implementations remain compiled once per product with the appropriate target definitions, their headers remain transitively available, and comparison of the former copies found no semantic divergence.

Important Files Changed

Filename	Overview
Core/GameEngine/CMakeLists.txt	Enables the nine shared header/source pairs on the Core INTERFACE source target consumed by both game libraries.
Generals/Code/GameEngine/CMakeLists.txt	Removes the duplicate Generals compilation entries while retaining the shared Core target dependency.
GeneralsMD/Code/GameEngine/CMakeLists.txt	Removes the duplicate Zero Hour compilation entries while retaining the shared Core target dependency.
scripts/cpp/unify_move_files.py	Adds commented records of the eighteen completed file moves without changing script execution.
Core/GameEngine/Source/Common/MessageStream.cpp	Moves the shared implementation into Core and removes one behavior-neutral trailing space.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Shared["Core GameEngine<br/>nine shared Common pairs"]
  G["g_gameengine<br/>RTS_GENERALS"]
  Z["z_gameengine<br/>RTS_ZEROHOUR"]
  GE["Generals executable and tools"]
  ZE["Zero Hour executable and tools"]
  Shared -->|INTERFACE sources| G
  Shared -->|INTERFACE sources| Z
  G --> GE
  Z --> ZE

Loading

_{Reviews (1): Last reviewed commit: "unify(common): Move identical files to C..." | Re-trigger Greptile}

[Skyaero42]

Validated with winmerge that these files are indeed identical.

[xezon]

Looking good