chore: Remove unused W3DCustomEdging class - #3079
Open
CryoTheRenegade wants to merge 1 commit into
Open
Conversation
The class was never instantiated or called anywhere. Remaining traces were a friend declaration in WorldHeightMap.h, four unused includes in Core sources, and two unreachable #ifdef TEST_CUSTOM_EDGING blocks that referenced an undeclared m_customEdging member. Closes TheSuperHackers#3028
xezon
approved these changes
Aug 8, 2026
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Any idea what the original author tried to achieve with that?
xezon
added
the
Refactor
xezon
changed the title
Author
|
Looks like a renderer for custom terrain blend edges, where instead of a soft gradient between two terrain types you'd draw a hand-authored ragged edge texture as a separate alpha-tested pass. The og author cloned W3DTreeBuffer as a template from what i can tell (the comments still say "trees" throughout). Never got finished or implemented afaik. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3028.
W3DCustomEdgingisn't used anywhere — nothing instantiates or calls it. What's left is just debris: afrienddeclaration inWorldHeightMap.h, four unused#includes in Core sources, and two#ifdef TEST_CUSTOM_EDGINGblocks that call into anm_customEdgingmember that was never declared (the macro is never defined either, so that code is unreachable and wouldn't even compile). This deletes the class files fromGenerals/andGeneralsMD/, drops them from both CMake lists (plus the already-commented Core lines), and cleans up the leftover friend declaration, includes, and dead blocks.g_generalsandz_generalsboth build clean with it gone. No behavior change.