tests(lost-cities): increase timeout for full-match transcript test to reduce flakiness - #2
Merged
Merged
Conversation
… simple render integration
…grate icon mapping into scene
… icons to PNG fallbacks (sharp)
… exist and map correctly
…t for better legibility when cards change shape
…leau card size a scaled version of hand card for consistent aspect ratio
…bounds (use bottom padding and origin=1)
…o 60s to avoid flakiness
SorraTheOrc
pushed a commit
that referenced
this pull request
Aug 1, 2026
…9J4VBL0037SPB) - AGENTS.md best practice #2: upgrade HandView/PileView from a suggestive 'When to use' note to a hard requirement — example games must render hands/piles through core engine components; bespoke hand rendering is not an accepted pattern. - Documented exception carve-outs: Golf 3x3 tableau grid (GolfRenderer.ts note) and Feudalism token/crop counters (CropIconRenderer), with guidance that exceptions must be justified in code comments/help text. - Blackjack (BlackjackScene.ts) cited as the canonical reference for standard hand rendering. - docs/DEVELOPER.md: new 'Hand & Pile Rendering' subsection after 'Adding an Example Game', cross-linking ui/ADAPTER-GUIDE.md and gym/GYM_INDEX.md; TOC updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small change increases the per-test timeout for the Lost Cities full-match transcript test from 15s to 60s to reduce intermittent CI/test runner flakes caused by longer-running AI match simulation runs.\n\n- File: tests/lost-cities/lost-cities-transcript.test.ts- Updated the single test timeout to 60000 ms.\n\nRationale:\n- The test runs a full AI-vs-AI match and occasionally exceeds 15s on CI or under load. Increasing the timeout stabilizes the suite without changing test logic.\n\nFollow-up:\n- Investigate and optimize the simulation path to avoid long-running behavior (separate work item).