Add offset handling for indices and result in take1()#298
Merged
lamblin merged 3 commits intoTheano:masterfrom Nov 28, 2016
Merged
Add offset handling for indices and result in take1()#298lamblin merged 3 commits intoTheano:masterfrom
lamblin merged 3 commits intoTheano:masterfrom
Conversation
Member
Author
|
I need some tests for the new case. They will come later. |
Member
|
Is there a bug report for this? If so, can you link to it? |
Member
|
seem good. |
Member
|
I added a link to what it fix. |
Member
Author
|
Now I have a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix gh-Theano/Theano#5285