Skip to content

Include "util.h" in "array.h".#394

Merged
abergeron merged 1 commit intoTheano:masterfrom
notoraptor:fix-inclusion-in-array-header
Mar 30, 2017
Merged

Include "util.h" in "array.h".#394
abergeron merged 1 commit intoTheano:masterfrom
notoraptor:fix-inclusion-in-array-header

Conversation

@notoraptor
Copy link
Copy Markdown
Contributor

It seems "util.h" is not automatically included when we use "array.h". I have encountered the error while trying to use GpuArray_ITEMSIZE(), defined in array.h, which uses gpuarray_get_elsize() defined in util.h.

/home/notoraptor/.theano/compiledir_Linux-4.4--generic-x86_64-with-debian-stretch-sid-x86_64-2.7.13-64/tmpQo9Y8T/mod.cpp: In member function ‘int {anonymous}::__struct_compiled_op_7cd93cb03039f5356757163adef008af::run()’:
/home/notoraptor/.local/include/gpuarray/array.h:197:63: error: ‘gpuarray_get_elsize’ was not declared in this scope
 #define GpuArray_ITEMSIZE(a) gpuarray_get_elsize((a)->typecode)
                                                               ^

This PR add the missing inclusion in array.h.

@abergeron

Copy link
Copy Markdown
Member

@nouiz nouiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for @abergeron to merge

@abergeron abergeron merged commit e9abc18 into Theano:master Mar 30, 2017
@notoraptor notoraptor deleted the fix-inclusion-in-array-header branch April 19, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants