Fix contiguous detection to properly handle F-contiguous input.#398
Fix contiguous detection to properly handle F-contiguous input.#398nouiz merged 2 commits intoTheano:masterfrom
Conversation
nouiz
left a comment
nouiz
left a comment
There was a problem hiding this comment.
Also, this would request test for inputs fortran and strided order in Theano or here. Currently, this is only tested in Theano.
| return err; | ||
| } | ||
|
|
||
| static inline int is_2d_contiguous(const GpuArray *a) { |
There was a problem hiding this comment.
The name isn't clear to what it does. Currently, it always expect a 2d inputs. If you want to keep that name,use ndim-1 and ndim-2 for which dimensions you checks. Otherwise, rename.
There was a problem hiding this comment.
It expects a 3d input and makes sure that the last two are contiguous.
There was a problem hiding this comment.
I'm ok with a rename, but to what?
There was a problem hiding this comment.
is_last_2d_contiguous and change the to use ndim -1 and ndim-2 in the code.
| GpuArray B; | ||
| GpuArray C; | ||
|
|
||
| size_t dims[3] = {2, 32, 32}; |
There was a problem hiding this comment.
typo, should be 2,3,3 how it can have passed ?
| GpuArray C; | ||
| ssize_t t; | ||
|
|
||
| size_t dims[3] = {2, 32, 32}; |
There was a problem hiding this comment.
should be 2,3,3, why the test passed?
|
I'm working on this, it's WIP. |
|
Now it's final. |
|
Don't forget to raise the version number |
|
We should bundle this and the disk cache in 0.6.4 |
2 participants
Fixes Theano/Theano#5795