Use secure HTTPS URLs where possible#430
Merged
nouiz merged 4 commits intoTheano:masterfrom May 5, 2017
Merged
Conversation
The request to https://www.opensource.org times out, but the domain without *www.* works. ``` $ curl -I https://opensource.org/licenses/bsd-license.php HTTP/1.1 200 OK ```
Even if the site is not loaded over HTTPS, it’s good practice to load assets over HTTPS if that is possible.
nouiz
reviewed
May 5, 2017
| (function() { | ||
| var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true; | ||
| ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js'; | ||
| ga.src = 'https://ssl.google-analytics.com/ga.js'; |
Member
There was a problem hiding this comment.
@slefrancois What do you think of that? I think it is good, but I'm not 100% sure.
Collaborator
There was a problem hiding this comment.
I'm not a web design expert, but it seems reasonable that google sites would be available in secure connections.
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all URLs could be converted, as there are still Web sites out there not having HTTPS set up correctly.