Test another possible fix for versionning #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This fix seems to work ! https://ci.appveyor.com/project/abergeron/libgpuarray-jv775/build/1.0.30-tlhouddp |
nouiz
reviewed
Sep 11, 2017
|
|
||
| requirements: | ||
| build: | ||
| - m2-git [win] |
Member
There was a problem hiding this comment.
why this fix the problem?
Also, we need to make the build fail if it can't generate a good version.
Member
There was a problem hiding this comment.
Because it is that git that doesn't like --dirty and gets used for the setup.py version.
Also we don't need it since we grab the source from the existing checkout.
Member
|
We can ignore the travis failure, that's fixed in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if appveyor generates the right version number for pygpu with this fix.
@abergeron