release: promote TypeMCP 0.2.2 examples remediation - #9
Conversation
sjungwon03-ai
left a comment
There was a problem hiding this comment.
Code Review — APPROVE
Clean release-promotion PR that advances the TypeMCP 0.2.2 dependency remediation from dev to main.
Summary
- Locks the production graph to published
@theorvane/type-mcp@0.2.2→@modelcontextprotocol/sdk@1.30.0→@hono/node-server@2.0.12with pinned versions in the lockfile. - Adds
npm run audit:prodto both thecheckscript and the existingverifyCI workflow. - Introduces a dedicated
release-promotion.ymlworkflow scoped to PRs targetingmainfromdev, with least-privilegecontents: readpermissions. - Adds a Vitest guard (
test/dependency-security.test.ts) that asserts exact lockfile versions, preventing accidental regressions to overrides. - README updated to document the dependency-security boundary.
Verdict
No code-quality blockers. CI (verify) passes on the current head. Merge-conflict state is informational only and does not affect this assessment.
sjungwon03-ai
left a comment
There was a problem hiding this comment.
Independent release-promotion review at exact head db7088f.
Two governance blockers:
- Required status check
release-promotionis absent at this head — only a stale run exists for 3155e9c. Themain-releaseruleset requires bothverifyandrelease-promotiongreen at the merged head. - PR conflicts with
main(diverged: main carries releases #1 and #5 that dev lacks). Back-merge/rebase dev onto main and re-verify before promotion.
Otherwise verified clean: exact-head lineage from approved PR #7, in-scope diff only, TypeMCP 0.2.2 -> MCP SDK 1.30.0 -> Hono node-server 2.0.12 consistent across package.json, lockfile, and npm registry, no local overrides, README accurate, verify green, no unresolved threads.
|
|
||
| on: | ||
| pull_request: | ||
| branches: [main] |
* release: publish verified TypeChain and TypeMCP examples (#1) Co-authored-by: sjungwon03 <> * release: promote audited MCP SDK graph to production (#5) * ci: require verified dev-to-main promotions * fix: pin examples MCP SDK to audited graph (#3) Co-authored-by: sjungwon03 <> --------- Co-authored-by: sjungwon03 <> * fix: retain published TypeMCP dependency contract
|
Superseded: PR #11 was squash-merged and therefore did not preserve the main parent relationship required to resolve this release conflict. A new merge-commit reconciliation PR will make main an ancestor of dev, then a fresh exact-head release-promotion PR will be opened with new checks and review. |
Summary
Promote the reviewed TypeMCP 0.2.2 examples dependency remediation from
devto release-onlymain.db7088f3b4e820f2a1083255c779efdf65875ad6Required release proof
mainclean reinstall, production audit, and runnable-example smokeCloses #8