fix: restore PR gates and OCR compatibility#2008
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe PR restructures pull-request validation into parallel quality gates with fail-closed aggregation, standardizes one-shot test commands, changes OCR image-limit handling to apply only to OCR candidates, updates related documentation and tests, and refreshes ACP and model registry metadata. ChangesPR quality gates
Light OCR image limits
ACP and model registry refresh
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant PullRequest
participant PRWorkflow
participant QualityJobs
participant PRRequired
PullRequest->>PRWorkflow: trigger validation
PRWorkflow->>QualityJobs: run parallel quality gates
QualityJobs-->>PRRequired: return job results
PRRequired->>PRRequired: apply branch-specific checks
PRRequired-->>PullRequest: report aggregate result
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr-requiredaggregate check for branch protection.Changes
Light OCR
Test entrypoints
test,test:main,test:renderer, andtest:coverageexplicitly one-shot.test:watchas the interactive entrypoint.PR Check
Run the following jobs in parallel:
statictest-maintest-renderertest-native-memorybuildAdditional workflow changes:
install:sharpstep, duplicated Memory scope check, and redundant Agent eval.pr-requiredwith explicit handling for failed, cancelled, and unexpectedly skipped dependencies.main-release-guardrequired formaintargets and allow it to skip only fordev.Generated registries
Summary by CodeRabbit
test-native-memory.vitest run).