File operations with folders in path #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- gl_file_exists() bug fix for empty repository - gl_get_file(), gl_push_file(), gl_delete_file() updated to URL encode file_path
Contributor
|
Thanks. I'll test it in a few days, when back from holidays 😃 |
…rresponding tests
6 tasks
Contributor
|
Less than 2 years to achieve this one... |
Contributor
Author
|
It's never too late 🙂.
I'm glad to have contributed to this project.
Keep up the good work !
…On Tue, 14 May 2024 at 16:58, Sébastien Rochette ***@***.***> wrote:
Less than 2 years to achieve this one...
This was a big one, and I am happy to close it :)
Thank you for your nice contribution!
I retrieved all your commit in this PR: #106
<#106>
—
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEGGYN5IMLCQZORB35HPHDTZCIRCLAVCNFSM57TX2FJ2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJRGA2DMNRTGI3A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sébastien,
I hope I've correctly interpreted your intention for the URL encoding.
Now all file functions accept a file_path that includes folders like "test-folder/dataset.csv" and each function takes care of URL encoding appropriately.
In order to make it work I've also modified
gl_file_list()adding a parameter to specify the path. This requires on the API call to add a query parameter (as documented here).I found what I think is a bug in
gl_file_exists()that I've fixed: looking for files in an empty repository produced an error.I have added tests to take into account folders trying to follow what you already did without folders.