fix(export): render all diagrams in PDF and image output - #255
Merged
Conversation
Deploying markdownviewer with
|
| Latest commit: |
723e763
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab75e3e8.markdownviewer.pages.dev |
| Branch Preview URL: | https://fix-render-diagrams-in-expor.markdownviewer.pages.dev |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ThisIs-Developer
force-pushed
the
fix/render-diagrams-in-exports
branch
from
September 1, 2026 20:06
a075b66 to
f8a29a1
Compare
ThisIs-Developer
force-pushed
the
fix/render-diagrams-in-exports
branch
from
September 1, 2026 20:45
81e1f71 to
e61fc22
Compare
ThisIs-Developer
force-pushed
the
fix/render-diagrams-in-exports
branch
from
September 1, 2026 21:04
fcee106 to
e61fc22
Compare
ThisIs-Developer
force-pushed
the
fix/render-diagrams-in-exports
branch
from
September 2, 2026 10:29
6850691 to
56d222c
Compare
ThisIs-Developer
force-pushed
the
fix/render-diagrams-in-exports
branch
from
September 2, 2026 11:06
6a9e577 to
981f3e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The raster export paths only re-rendered Mermaid, ABC, and math, so the remaining diagram engines were captured as loading placeholders. Browser-print export also changed the application theme while preparing a differently themed PDF, and late light print rules caused white tables and diagrams inside dark PDFs. Markmap additionally reused its interactive viewport transform in print, shrinking trees to a few pixels inside a large SVG.
How it was tested
npm test— 176 Chromium tests passed for the initial implementationnpx playwright test tests/e2e/export.spec.js tests/e2e/markmap-export.spec.js --project=chromium— export coverage passednpx playwright test tests/e2e/rich-content.spec.js --project=chromium -g "renders Markmap"— live Markmap rendering passedDocumentation
No public documentation changes are required; the export choices remain self-explanatory and continue to be remembered automatically.