Unify provider sign-in on the hidden flow and match actions to errors - #120
Merged
Conversation
Every Sign in button (setup card row, composer notices) now drives the same server-side login flow the settings panel uses, through a shared useProviderConnectFlow hook: inline "Signing in" status with the live output line where the user clicked, no thread terminal takeover, and a hand-off to the settings panel (deep-linked to the instance) when a run stalls past the auto-expand threshold or fails while interactive. On the held-send notice, a successful sign-in triggers the existing recheck, so the held message releases itself through the normal preflight gate with no second click. A replay guard keeps an attached surface from treating a finished session from minutes ago as the run the user just started. The provider status notice now earns its actions from the structured snapshot instead of always offering Refresh and Diagnostics: signed out gets Sign in alone, a missing CLI gets Open Settings plus Refresh, disabled gets Open Settings, and probe trouble keeps Refresh plus Diagnostics. URLs in provider status details render as real links via a shared linkifier, so the Claude install address stops being dead text.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
vouch:trusted
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodeQL flagged the test's tag-stripping regex as incomplete multi character sanitization. It was never sanitizing, just recovering text content from static markup, but the pure segment splitter's documented invariant (concatenated segments reproduce the input) states the same property directly without the alert-bait pattern.
Screenshot verification caught the settings hand-off restarting the stall timer: a user who already waited out the threshold in chat arrived at settings and waited it out again before the terminal appeared. The ?instance= deep link now threads through the provider card to the login flow, which opens its terminal immediately while the session is active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the two approved follow-ups from the onboarding review: per-error actions on provider status surfaces, and one sign-in flow everywhere.
Unified hidden sign-in
useProviderConnectFlow(subscription, event folding via the existingproviderConnectFlow.logicstate machine, auto-expand timing, start/stop). The settings panel, the first-run setup card row, and the composer notices all mount the same hook now; settings lost ~130 duplicated lines./settings/providers?instance=<id>(new search param) where the full terminal re-attaches to the same live session.onSucceededonly fires for runs this surface watched begin, so a stale success can't auto-send anything.Per-error status actions + linkify
resolveProviderStatusNoticeActionsreads structured snapshot fields only: signed out → Sign in alone; not installed → Open Settings + Refresh; disabled → Open Settings; probe trouble / can't-verify → Refresh + Diagnostics (unchanged). URLs in provider status details render as anchors via a sharedLinkifiedText, fixing the dead Claude install link in settings.Testing
vp fmt/vp lint/vp run typecheckgreen; web unit suite 2074 pass.