PATCH: update currency.csv with titles #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #349 Following the merge of #406 which added titles to countryCode.csv, this adds titles to currency.csv. There are also some formatting improvements to the csv file to make parsing a bit more robust. The schema states that the currency codes are pegged to ISO 4217, which is the standard for currency codes: https://en.wikipedia.org/wiki/ISO_4217 The codes included as part of 360Giving's currency.csv list span the "active codes" and the "historical codes". In order to preserve the integrity of the existing codelist, I added the titles by performing a left join onto the existing codelist. This ensured that no new codes were added, and that only codes with titles had titles applied to them. Reviewers should note that some codes share titles e.g. the historical ISJ and the contemporary ISK are both named "Icelandic króna".
Contributor
|
A week has passed since the PATCH was proposed in the forum and by email to the Stewardship Committee, with no objections received, so this PATCH is now considered approved. |
mariongalley
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #349
Following the merge of #406 which added titles to countryCode.csv, this
adds titles to currency.csv. There are also some formatting improvements
to the csv file to make parsing a bit more robust.
The schema states that the currency codes are pegged to ISO 4217, which
is the standard for currency codes:
https://en.wikipedia.org/wiki/ISO_4217
The codes included as part of 360Giving's currency.csv list span the
"active codes" and the "historical codes".
In order to preserve the integrity of the existing codelist, I added the
titles by performing a left join onto the existing codelist. This
ensured that no new codes were added, and that only codes with titles
had titles applied to them.
Reviewers should note that some codes share titles e.g. the historical
ISJ and the contemporary ISK are both named "Icelandic króna".