Skip to content

Add secure connection option for S3 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenHall-1 merged 1 commit into from
May 15, 2025
Merged

Add secure connection option for S3 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/import/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func main() {

logger.Info("Database connected.")

s3ImportClient, err := minio.New(config.S3.Import.Endpoint, config.S3.Import.AccessKey, config.S3.Import.SecretKey, true)
s3ImportClient, err := minio.New(config.S3.Import.Endpoint, config.S3.Import.AccessKey, config.S3.Import.SecretKey, config.S3.Import.Secure)
if err != nil {
logger.Fatal("Failed to connect to Import S3", zap.Error(err))
return
Expand All @@ -57,7 +57,7 @@ func main() {
logger.Info("Import S3 connected.")
utils.S3ImportClient = s3ImportClient

s3ArchiveClient, err := minio.New(config.S3.Archive.Endpoint, config.S3.Archive.AccessKey, config.S3.Archive.SecretKey, true)
s3ArchiveClient, err := minio.New(config.S3.Archive.Endpoint, config.S3.Archive.AccessKey, config.S3.Archive.SecretKey, config.S3.Archive.Secure)
if err != nil {
logger.Fatal("Failed to connect to Archive S3", zap.Error(err))
return
Expand Down
2 changes: 2 additions & 0 deletions internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,15 @@ type Config struct {
S3 struct {
Import struct {
Endpoint string `env:"ENDPOINT,required"`
Secure bool `env:"SECURE" envDefault:"true"`
AccessKey string `env:"ACCESS_KEY,required"`
SecretKey string `env:"SECRET_KEY,required"`
Bucket string `env:"BUCKET,required"`
} `envPrefix:"IMPORT_"`

Archive struct {
Endpoint string `env:"ENDPOINT,required"`
Secure bool `env:"SECURE" envDefault:"true"`
AccessKey string `env:"ACCESS_KEY,required"`
SecretKey string `env:"SECRET_KEY,required"`
Bucket string `env:"BUCKET,required"`
Expand Down