Skip to content

Add secure connection option for S3#3

Merged
BenHall-1 merged 1 commit intoTicketsBot-cloud:mainfrom
DanPlayz0:feat/support-insecure-s3
May 15, 2025
Merged

Add secure connection option for S3#3
BenHall-1 merged 1 commit intoTicketsBot-cloud:mainfrom
DanPlayz0:feat/support-insecure-s3

Conversation

@DanPlayz0
Copy link
Copy Markdown
Contributor

This PR adds a feature for users who do not want to deal with TLS with S3. This is mostly a feature for self-hosted instances of the bot.

This pull request introduces a configuration enhancement to make the S3 connection security settings configurable via environment variables. The most important changes include adding a Secure field to the S3 configuration structs and updating the S3 client initialization logic to use this new field.

Configuration Enhancements:

  • internal/config/config.go: Added a Secure field (type bool) to both the Import and Archive S3 configuration structs. This field is mapped to the SECURE environment variable with a default value of true.

S3 Client Initialization Updates:

  • cmd/import/main.go: Updated the s3ImportClient initialization to use the config.S3.Import.Secure field instead of a hardcoded true value.
  • cmd/import/main.go: Updated the s3ArchiveClient initialization to use the config.S3.Archive.Secure field instead of a hardcoded true value.

More Pull Requests

@BenHall-1 BenHall-1 merged commit dc70961 into TicketsBot-cloud:main May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants