Add secure connection option for S3#3
Merged
BenHall-1 merged 1 commit intoTicketsBot-cloud:mainfrom May 15, 2025
Merged
Conversation
This was referenced May 15, 2025
BenHall-1
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a feature for users who do not want to deal with TLS with S3. This is mostly a feature for self-hosted instances of the bot.
This pull request introduces a configuration enhancement to make the S3 connection security settings configurable via environment variables. The most important changes include adding a
Securefield to the S3 configuration structs and updating the S3 client initialization logic to use this new field.Configuration Enhancements:
internal/config/config.go: Added aSecurefield (typebool) to both theImportandArchiveS3 configuration structs. This field is mapped to theSECUREenvironment variable with a default value oftrue.S3 Client Initialization Updates:
cmd/import/main.go: Updated thes3ImportClientinitialization to use theconfig.S3.Import.Securefield instead of a hardcodedtruevalue.cmd/import/main.go: Updated thes3ArchiveClientinitialization to use theconfig.S3.Archive.Securefield instead of a hardcodedtruevalue.More Pull Requests