refactor(spa): extract firlaw inline edits to separate components - #5
Merged
Tietve merged 3 commits intoMay 26, 2026
Merged
Conversation
added 3 commits
May 18, 2026 22:18
- titlebar height: 40px -> 56px (h-10 -> h-14) - icon buttons: 24-32px -> 40x40 with rounded-[10px] - icon size: small -> medium - button gap: 1 -> 2 (4px -> 8px) - add FirlawLogo wordmark (burgundy + gold + charcoal) before sidebar toggle - session-header: open-folder + review become pills with Vietnamese labels - reload-skills + file-tree toggle scaled up to 40x40 Rationale: target audience are older lawyers, need bigger touch targets (Apple HIG 44px / Material 48px) and softer visuals (larger radius, gentler transitions) than coder-density default.
- firlaw-overrides.css: CSS variables for titlebar height/button sizing, session header open-dir + action button sizing, label visibility rules - firlaw-file-actions.tsx: context menu with delete/rename/upload/mkdir logic extracted from file-tree.tsx (~175 lines → ~14 lines net diff) - firlaw-side-panel-actions.tsx: upload + mkdir root buttons extracted from session-side-panel.tsx (~55 lines → 1 component render) - titlebar.tsx: revert inline class overrides to upstream values; CSS handles sizing via .titlebar-icon + header[data-tauri-drag-region] - session-header.tsx: revert inline sizing overrides; CSS classes applied - Upstream file diffs reduced by ~85% for easier future merges
…ctor - Restore size="large" on reload-skills IconButton (was silently dropped) - Restore size="medium" on review and file-tree Icon elements in session-header - Restore size-5 container for file-tree icon (was incorrectly size-4) - Remove .titlebar-icon [data-component="icon"] CSS rule (unverified selector) - Remove unused --firlaw-titlebar-icon-size CSS variable
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file-tree.tsx→firlaw-file-actions.tsxsession-side-panel.tsx→firlaw-side-panel-actions.tsxfirlaw-overrides.csswith CSS variablesWhat changed
file-tree.tsxsession-side-panel.tsxtitlebar.tsxfirlaw-overrides.csssession-header.tsxNew files
firlaw-overrides.css— CSS variables for Firlaw sizing overridesfirlaw-file-actions.tsx— Context menu component (delete, rename, upload, mkdir)firlaw-side-panel-actions.tsx— Upload + Create folder buttonsTest plan