ArraySchema.toString() checks if domain is set #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #30999: Error when adding break point between schema creation and setting its domain. |
ihnorton
approved these changes
Jun 28, 2023
Member
ihnorton
left a comment
ihnorton
left a comment
There was a problem hiding this comment.
Please add a regression test before merging, if possible.
DimitrisStaratzis
force-pushed
the
dstara/sc-30999/error-when-adding-break-point-between-schema
branch
from
c3da7dd to
145aefb
Compare
DimitrisStaratzis
deleted the
dstara/sc-30999/error-when-adding-break-point-between-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full description can be found in the shortcut story. This was causing the debugger to crash if a breakpoint was set between the ArraySchema creation and setting its domain.