Skip to content

ArraySchema.toString() checks if domain is set #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2023
Merged

ArraySchema.toString() checks if domain is set #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/io/tiledb/java/api/ArraySchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public class ArraySchema implements AutoCloseable {

private Context ctx;
private ArrayType arrayType;
private boolean domainIsSet = false;
private HashMap<String, Attribute> attributes;

private SWIGTYPE_p_tiledb_array_schema_t schemap;
Expand Down Expand Up @@ -331,6 +332,7 @@ public Domain getDomain() throws TileDBError {
public void setDomain(Domain domain) throws TileDBError {
ctx.handleError(
tiledb.tiledb_array_schema_set_domain(ctx.getCtxp(), getSchemap(), domain.getDomainp()));
domainIsSet = true;
}

/**
Expand Down Expand Up @@ -771,7 +773,7 @@ public String toString() {
StringBuilder s = new StringBuilder("ArraySchema<");
s.append(getArrayType().name());
s.append(" ");
s.append(getDomain());
if (domainIsSet) s.append(getDomain());
for (Map.Entry e : getAttributes().entrySet()) {
s.append(" ");
s.append(e.getValue());
Expand Down
1 change: 1 addition & 0 deletions src/test/java/io/tiledb/java/api/ArraySchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public ArraySchema schemaCreate(Context ctx, ArrayType arrayType, Layout cellOrd
ArraySchema schema = new ArraySchema(ctx, arrayType);
schema.setTileOrder(Layout.TILEDB_ROW_MAJOR);
schema.setCellOrder(cellOrder);
Assert.assertNotNull(schema.toString());
schema.setDomain(domain);
schema.addAttribute(a1);
return schema;
Expand Down