Enhance build system to add TileDB if not installed already #118
Merged
eddelbuettel merged 10 commits intomasterfrom May 11, 2020
Merged
Enhance build system to add TileDB if not installed already #118eddelbuettel merged 10 commits intomasterfrom
eddelbuettel merged 10 commits intomasterfrom
Conversation
Omitting libbz2 and libz which we get from R
Revert "Provide additional aliases for S4 subsetting methods" This reverts commit a793160.
eddelbuettel
requested review from
Shelnutt2,
aaronwolen,
ihnorton,
joe-maley and
stavrospapadopoulos
aaronwolen
reviewed
May 11, 2020
configure.ac
Outdated
| [], | ||
| [AC_MSG_ERROR([unable to find tiledb/tiledb.h])]) | ||
| if test x"${have_tiledb}" = x"0"; then | ||
| AC_MSG_RESULT([** Installting TileDB]) |
Contributor
Author
There was a problem hiding this comment.
Thanks for catching that, fixed in 71d1cb7.
aaronwolen
approved these changes
May 11, 2020
Shelnutt2
approved these changes
May 11, 2020
Member
Shelnutt2
left a comment
Shelnutt2
left a comment
There was a problem hiding this comment.
Excellent addition, few minor question/comments, but overall lgtm.
| if test -d src/tiledb-inst/lib64; then | ||
| ## checking for lib64 used e.g. on Fedora | ||
| AC_MSG_RESULT([** Now using src/tiledb-inst/lib64/]) | ||
| AC_SUBST([TILEDB_LIBS], "tiledb-inst/lib64/libtiledb.a tiledb-inst/lib64/libtbb.a tiledb-inst/lib64/libssl.a tiledb-inst/lib64/libcrypto.a tiledb-inst/lib64/libzstd.a tiledb-inst/lib64/liblz4.a") |
Member
There was a problem hiding this comment.
When we have the .pc file, will we be able to avoid the static list of libs?
| mkdir build | ||
| cd build | ||
| ../tiledb-src/bootstrap --prefix=../tiledb-inst --enable-static-tiledb --force-build-all-deps | ||
| make -j 8 |
| [], | ||
| [AC_MSG_ERROR([unable to find tiledb/tiledb.h])]) | ||
| if test x"${have_tiledb}" = x"0"; then | ||
| AC_DEFUN([AC_PROG_CMAKE], [AC_CHECK_PROG(have_cmake,cmake,yes)]) |
Member
There was a problem hiding this comment.
some system the cmake command might be cmake3, this is mostly Ubuntu 16.04/RHEL 6 or 7.
Contributor
Author
|
Thanks for the two approvals. I'll merge this to clear the stack but with the understanding that it is ultimately work in progress (as we may need a richer config, support more platforms etc pp). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request for the R package adds
configure.acto see if a very simple TileDB program can be builtMore to do in terms potentially accelerating build by pre-building static libraries as well as expanding to to more optional features. We benefit from a recent increase of the build time limit at R-Hub from 10 minutes to 20 minutes -- so we probably need the former ("faster build") to get the latter ("richer build").
The branch is identical to feature/build_tiledb branch but reverts out the one commit underlying the parallel PR #117 (which adds S4 aliases to the docs) to make the comparison simpler and cleaner.