Skip to content

regroup code that needs TILEDB_DEPRECATED#136

Merged
eddelbuettel merged 3 commits intomasterfrom
de/deprecation
Jun 30, 2020
Merged

regroup code that needs TILEDB_DEPRECATED#136
eddelbuettel merged 3 commits intomasterfrom
de/deprecation

Conversation

@eddelbuettel
Copy link
Contributor

This is a very straightforward regreouping of code that was previously in src/libtiledb.cpp. The routines calling into deprecated API entry points have now been collected in a separate file, and only that file is compiled with the flag.

Currently, the older (R) types tiledb_dense and tiledb_sparse rely on some deprecated routines. And while we could rewrite this, it may be preferable to just focus on the newer tiledb_array and keep the two older ones around until we deprecate them from the R package at some point.

The net benefit is that we now compile a lot less code under TILEDB_DEPRECATED making it a lot easier to spot new deprecations if an when they arise.

Otherwise, no code changes. Just some reshuffling of deck chairs.

// [[Rcpp::plugins(cpp11)]]


// declaratons needed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo, declaratons -> declaratIons

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And another typo. Here is what R's fortunes package has to say about this:

R> fortunes::fortune(112)           

 I think we can reject the null hypothesis of "Dirk can type" at all  
 convential significance levels.         
    -- Dirk Eddelbuettel (after several users including himself had               
       misspelled Ubuntu as Umbutu or Ubunto)                     
       R-help (April 2005)                  

R>      

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9d61681.

Also pushed a commit updating RcppExports.{R,cpp} which are "different" in that the sequence of generated glue functions is different due to the "reordering" of input with the new file src/declarations.cpp. Still no source changes whatsoever.

@eddelbuettel eddelbuettel merged commit d43f898 into master Jun 30, 2020
@eddelbuettel eddelbuettel deleted the de/deprecation branch July 1, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants