regroup code that needs TILEDB_DEPRECATED#136
Merged
eddelbuettel merged 3 commits intomasterfrom Jun 30, 2020
Merged
Conversation
ihnorton
approved these changes
Jun 30, 2020
src/deprecation.cpp
Outdated
| // [[Rcpp::plugins(cpp11)]] | ||
|
|
||
|
|
||
| // declaratons needed |
Member
There was a problem hiding this comment.
small typo, declaratons -> declaratIons
Contributor
Author
There was a problem hiding this comment.
And another typo. Here is what R's fortunes package has to say about this:
R> fortunes::fortune(112)
I think we can reject the null hypothesis of "Dirk can type" at all
convential significance levels.
-- Dirk Eddelbuettel (after several users including himself had
misspelled Ubuntu as Umbutu or Ubunto)
R-help (April 2005)
R>
Contributor
Author
There was a problem hiding this comment.
Fixed in 9d61681.
Also pushed a commit updating RcppExports.{R,cpp} which are "different" in that the sequence of generated glue functions is different due to the "reordering" of input with the new file src/declarations.cpp. Still no source changes whatsoever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very straightforward regreouping of code that was previously in
src/libtiledb.cpp. The routines calling into deprecated API entry points have now been collected in a separate file, and only that file is compiled with the flag.Currently, the older (R) types
tiledb_denseandtiledb_sparserely on some deprecated routines. And while we could rewrite this, it may be preferable to just focus on the newertiledb_arrayand keep the two older ones around until we deprecate them from the R package at some point.The net benefit is that we now compile a lot less code under
TILEDB_DEPRECATEDmaking it a lot easier to spot new deprecations if an when they arise.Otherwise, no code changes. Just some reshuffling of deck chairs.