do not attempt to alter num_tbb_threads#158
Merged
eddelbuettel merged 1 commit intomasterfrom Aug 24, 2020
Merged
Conversation
ihnorton
approved these changes
Aug 24, 2020
Member
ihnorton
left a comment
ihnorton
left a comment
There was a problem hiding this comment.
Seems fine given TBB is disabled in the default target binaries (possibly why it is failing). And TBB going away soon, of course.
Contributor
Author
|
The package has a number of possible build configurations, but this small change is also seen as helping against the current dev branch. So thanks -- merging now. |
This was referenced Aug 24, 2020
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
num_tbb_threadsentry does not like to encounter a changed a value, so not setting it from here prevents some initialization failures seen in some instances.