Skip to content

Vignette updates#184

Merged
eddelbuettel merged 2 commits intomasterfrom
de/vignette_update
Nov 4, 2020
Merged

Vignette updates#184
eddelbuettel merged 2 commits intomasterfrom
de/vignette_update

Conversation

@eddelbuettel
Copy link
Contributor

This updates the vignette to the tiledb_array() preference over tiledb_dense() and tiledb_sparse() (and edits in a few places).


Extracts column 2 and rows 1 to 2 from A, returning a list object as there are multiple attributes.
The first example extracts rows 1 to 2 and column 2 from an array. It also limits the selection to
just one attribute (via `attrs`), asks for the return to be `data.frame` (instead of a simpler list)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return to be a data.frame

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0a3711a

[,1]
[1,] 11
[2,] 12
R> A <- tiledb_array(uri = uri, attrs = "b", , as.data.frame=TRUE, extended=FALSE))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra comma after attrs = "b", unless that was intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0a3711a

Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found two minor typos but it looks good otherwise!

@eddelbuettel eddelbuettel merged commit bee369d into master Nov 4, 2020
@eddelbuettel eddelbuettel deleted the de/vignette_update branch November 4, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants