Merged
Conversation
aaronwolen
approved these changes
Dec 30, 2020
Member
aaronwolen
left a comment
There was a problem hiding this comment.
Two small comments but LGTM!
R/TileDBArray.R
Outdated
| #' @slot query_layout An optional character value | ||
| #' @slot datetimes_as_int64 A logical value | ||
| #' @slot encryption_key A character value | ||
| #' @slot timestamp A POSIXct datimetime variable |
Contributor
Author
There was a problem hiding this comment.
And we all sing now :"dah dah dah dahdatime".
Nice catch -- fixed.
R/TileDBArray.R
Outdated
| #' \code{POSIXct} or \code{nanotime} objects. | ||
| #' @param encryption_key optional A character value with an AES-256 encryption key | ||
| #' in case the array was written with encryption. | ||
| #' @param timestamp optional A Datetime value determining where in time the array is |
Member
There was a problem hiding this comment.
Maybe mention it must be POSIXct?
b714f92 to
95438c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds high-level support for timestamps at the
tiledb_arraylevel. A simple illustration is included as well (and the basis of added unit tests): we open an array, write three rows at a recording timestamp, sleep a little and write three more rows. The expected reads before first, after first, before second and after second time stamp are the expected 0, 3, 3, and 6 rows.