Add support for Nullable elements#211
Merged
eddelbuettel merged 26 commits intomasterfrom Feb 17, 2021
Merged
Conversation
aaronwolen
approved these changes
Feb 17, 2021
aaronwolen
reviewed
Feb 17, 2021
R/Attribute.R
Outdated
| #' Set the TileDB Attribute Nullable flags | ||
| #' | ||
| #' @param attr A TileDB Attribute object | ||
| #' @param flag A boolean flag to turn \sQuote{Nullable} on or of |
Contributor
Author
There was a problem hiding this comment.
Thanks for catching that! Fixed now (twice even as I promptly typo'ed the commit log).
eddelbuettel
force-pushed
the
de/nullable_support
branch
from
564b66c to
d964275
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for 'nullable' elements by supporting the interval validity map vectors. Numeric and character dimension and attributes are supported, and unit tests have been added.
(The commit dates below are reset from a rebase yesterday. Work on this had progressed over a two-week period; our CI runners will have logs from the intermediate runs.)