Default dense data.frame writes to column major layout#226
Merged
eddelbuettel merged 2 commits intomasterfrom Apr 5, 2021
Merged
Default dense data.frame writes to column major layout#226eddelbuettel merged 2 commits intomasterfrom
eddelbuettel merged 2 commits intomasterfrom
Conversation
eddelbuettel
requested review from
Shelnutt2,
aaronwolen and
stavrospapadopoulos
Shelnutt2
approved these changes
Apr 5, 2021
stavrospapadopoulos
approved these changes
Apr 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen in issue #222, dense arrays written from a
data.frameobject defaulted to row-major layout. As column-major is more natural for R, the PR reverts this from row-major to column-major.The only other changes was to account for the change in a number of unit tests.