Support datetime dimenions column range restrictions#233
Merged
eddelbuettel merged 4 commits intomasterfrom Apr 28, 2021
Merged
Support datetime dimenions column range restrictions#233eddelbuettel merged 4 commits intomasterfrom
eddelbuettel merged 4 commits intomasterfrom
Conversation
eddelbuettel
force-pushed
the
de/dimension_datetime
branch
from
859788f to
a1fe673
Compare
aaronwolen
approved these changes
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DATETIME_* data is stored, we generally follow the NumPy format and transform values. An example is DATETIME_YEAR, the current year is store as 51 derivided as the current year's value minus the year of the epoch. However, R users would submit selection ranges via pairs of
<minvalue, maxvalue>for the range as R objects, using e.g. aDateobject such asas.Date(2010-01-01)to express, say, the year 2010. We have to map these values to the NumPy representation to properly set up constraints.An existing unit test has been expanded, for each written column a subset is then requested and checked.