Refactor range setting for tiledb_array#236
Merged
eddelbuettel merged 4 commits intomasterfrom May 10, 2021
Merged
Conversation
eddelbuettel
force-pushed
the
de/update_range_setting
branch
from
24daed9 to
3cddb42
Compare
aaronwolen
approved these changes
May 10, 2021
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the code for range setting via either 'square bracket' indexing (i.e. via
A[i:j, k:l]or variations thereof) or theselected_ranges()helper function by combining the former into the code path as the latter. We also allow for generalized use ofselected_ranges()via named element lists, no longer requiring all possible dimensions to be present (if when NULL). The unit test file, and help documentation, were extended too.As the dimension setting test file was using the same small-to-medium size Palmer Penguins data set (when present), we now also suggest the package supplying it. This is an inexpensive Suggests: as the package has not further dependencies itself (but only Suggests: too).