Add small tweaks to make tests pass with R 3.6.3#243
Merged
eddelbuettel merged 2 commits intomasterfrom May 13, 2021
Merged
Conversation
Shelnutt2
approved these changes
May 13, 2021
Contributor
Author
|
The UI here is stooopid:
That is due to Azure 'canceling' because I piled on a new commit. Sad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue that some tests failed under R 3.6.* (having to do with the fact that the default behavior for stringsAsFactors switched from pre-R 4.0.0 to R 4.0.0). For character columns, our code always treats them as character and never as factors (just as R now does) but in two or three spots the tests did not account for that and now do a (conditional on R < 4.0.0) conversion.