Skip to content

Support array opening at start / end timestamps#272

Merged
eddelbuettel merged 5 commits intomasterfrom
de/ch8062/open_timestamp
Jul 23, 2021
Merged

Support array opening at start / end timestamps#272
eddelbuettel merged 5 commits intomasterfrom
de/ch8062/open_timestamp

Conversation

@eddelbuettel
Copy link
Copy Markdown
Contributor

This PR support the extended timestamp format for arrays:

  • adds dedicated setter and getter and start and end timestamp
  • updates tiledb_array interface with start and end timestamp support
  • continues (but marked as 'deprecated') support for the older 'timestamp' argument
  • adds new tests, old test code runs as is (until deprecated function removed),
  • old tests also recast in new arguments

@shortcut-integration
Copy link
Copy Markdown

This pull request has been linked to Clubhouse Story #8062: Support timestamp API changes in TileDB 2.3.

Copy link
Copy Markdown
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as-is if you want to merge, just noting the refactoring we discussed will avoid a second reopen (either in this PR or as followup).

@eddelbuettel
Copy link
Copy Markdown
Contributor Author

I will merge now, and start from this as a baseline. Smaller cadences haved work well.

@eddelbuettel eddelbuettel merged commit 8141736 into master Jul 23, 2021
@eddelbuettel eddelbuettel deleted the de/ch8062/open_timestamp branch July 23, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants