Merged
Conversation
|
This pull request has been linked to Clubhouse Story #9673: Communicate in array accessor when query may be incomplete. |
ihnorton
approved these changes
Aug 16, 2021
Member
ihnorton
left a comment
ihnorton
left a comment
There was a problem hiding this comment.
LGTM, but please get Aaron's sign-off too since this impacts UX.
@aaronwolen the motivation here is that we currently don't indicate when a query is incomplete, so a user could get partial results from their query and proceed without realizing. We are hoping to incorporate a default "run to completion" mode (possibly via libtiledb core) in the future.
Member
|
Thanks for the helpful context, @ihnorton. I think issuing a warning in the event of an incomplete query is the way to go. |
aaronwolen
approved these changes
Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a missing check for query status to the
[accessor function most commonly used. This does the right thing for an R user by wrappingwarning()as local configuration can then be used in both directions: turning warnings into errors (i.e. halting) or ignoring warning, or, of course, doing nothing and getting them displayed.