Store and optionally access query status#285
Merged
eddelbuettel merged 5 commits intomasterfrom Aug 17, 2021
Merged
Conversation
|
This pull request has been linked to Clubhouse Story #9715: Returned object does not carry query status result. |
aaronwolen
approved these changes
Aug 17, 2021
Member
aaronwolen
left a comment
aaronwolen
left a comment
There was a problem hiding this comment.
Small typo in the docs but otherwise looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stores the query status result in the (existing) per-package environment (when using the default getter
[for arrays), and adds a getter to retrieve (which is handy when we do not directly construct the query object).The status is also added as an attributed to the returned object.
Tests have been updated to test 'equivalence' (ignoring attributes and names) rather than equality of returned object and reference object (which will not have the query status attribute).