Merged
Conversation
|
This pull request has been linked to Clubhouse Story #9895: Minor test polish for fragment info. |
aaronwolen
approved these changes
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent PR #286 added support for fragment info with a number of tests.
One test compared the fragment info timestamp (at R's end a Datetime aka POSIXct) to the current date. This did not adjust to TZ settings so at 7pm or later (under US Central time) it would break as ... the other time comes up at UTC and is the next day. That has been fixed.
The fragment info tests missed a call to array_consolidate (after a dual write to an array) to actually see unconsolidated metadata. Thanks to @Shelnutt2 for the hint; that has been added too.