Add support for 'piped' query access to tiledb_array#301
Merged
eddelbuettel merged 8 commits intomasterfrom Sep 23, 2021
Merged
Add support for 'piped' query access to tiledb_array#301eddelbuettel merged 8 commits intomasterfrom
eddelbuettel merged 8 commits intomasterfrom
Conversation
aaronwolen
approved these changes
Sep 22, 2021
ihnorton
approved these changes
Sep 23, 2021
Member
ihnorton
left a comment
ihnorton
left a comment
There was a problem hiding this comment.
Looks great! Should probably add some smoke-tests as follow-up.
Member
(Or maybe there are inline tests in the .Rd files that I missed, in which case disregard) |
Contributor
Author
|
Yes a simple check is a good idea and I'll add that. |
Contributor
Author
|
Tests added along with one small cleanup on the does-not-need-to-be-exported helper function, all good so merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for 'pipe-able' filtering and selection. The functions are prefix to not create an issue with R's
filter()which sadly has no generic so that adding new dispatches is not directly possible. Using a prefix is one possibility, and done here.