Do not finalize read queries

[eddelbuettel]

The one-line change below is the difference between whether an identical query sent to one of

• s3://genomic-datasets/biological-databases/data/tables/gtex-analysis-rnaseqc-gene-tpm
• tiledb://TileDB-Inc/gtex-analysis-rnaseqc-gene-tpm

succeeds in both cases. Without the change it will not work for the second uri.

A simple test script follows, Calling with any one of b or bad or tile will show the issues---by failing to retrieve data---unless the change in the PR is made.

#!/usr/bin/Rscript

library(tiledb)
argv <- commandArgs(TRUE)

## good
uri <- "s3://genomic-datasets/biological-databases/data/tables/gtex-analysis-rnaseqc-gene-tpm"

## bad
if (length(argv) > 0 && is.finite(match(argv, c("b", "bad", "tile"))))
    uri <- "tiledb://TileDB-Inc/gtex-analysis-rnaseqc-gene-tpm"

cat("Using uri", uri, "\n")
gtex_array <- tiledb_array(uri = uri, is.sparse = TRUE, attrs = "tpm", return_as = "tibble")
res <- gtex_array["ENSG00000199405.1", ]
print(res)

[shortcut-integration]

This pull request has been linked to Shortcut Story #9988: bad_alloc when querying tiledb cloud array with 1kg sample metadata.

[ihnorton]

Pls remove the line and update the comment as discussed, otherwise LGTM. Good catch!