Deprecate use of TILEDB_CHAR (and TILEDB_ANY)#353
Merged
eddelbuettel merged 2 commits intomasterfrom Jan 20, 2022
Merged
Conversation
|
This pull request has been linked to Shortcut Story #13292: Deprecate use of TILEDB_CHAR and TILEDB_ANY in the R package. |
ihnorton
reviewed
Jan 20, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows a change in TileDB Embedded and reduces use of
TILEDB_CHARandTILEDB_ANY. Most uses are simple filtering over possible types and can remain, but one use ofTILEDB_CHARwas changed toTILEDB_STRING_ASCII.A recent regression in refactored readers caused one dense reading test to fail under 2.7.0 so this PR also conditions the test for now while the regression is addressed. This only affects current development sources of TileDB Embedded.