Skip to content

Further unit test cleanup #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddelbuettel merged 4 commits into from
Feb 1, 2022
Merged

Further unit test cleanup #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b3c8a6
unload arrow package at end of test file
eddelbuettel Feb 1, 2022
fb69735
reactivate schema tests
eddelbuettel Feb 1, 2022
1a9254e
also deactivate detach again
eddelbuettel Feb 1, 2022
2fe183c
refine arrow cleanup some more
eddelbuettel Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions inst/tinytest/test_arrowio.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,3 +177,7 @@ for (i in c(1:7,9:10)) {
expect_equivalent(df[,i], 1:10)
}
expect_equivalent(df[,8], as.integer64(1:10))

## detaching arrow should not be necessary as we generally do not need to unload
## packages but had been seen as beneficial in some instanced so there is now an option
if (Sys.getenv("R_TESTING_CLEANUP", "") == "yes") detach(package:arrow, unload=TRUE)
20 changes: 9 additions & 11 deletions inst/tinytest/test_tiledbarray.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,17 +991,15 @@ expect_equal(tiledb_array_get_non_empty_domain_from_name(arr, "d1"), c(1, 3))
expect_equal(tiledb_array_get_non_empty_domain_from_index(arr, 2), c("a", "c"))
expect_equal(tiledb_array_get_non_empty_domain_from_name(arr, "d2"), c("a", "c"))

if (FALSE) { # this tests fine in isolation but croaks in bulk
## access schema from uri
schema2 <- schema(tmp)
expect_true(is(schema2, "tiledb_array_schema"))
expect_equal(schema, schema2)

## access schema from array
schema3 <- schema(arr)
expect_true(is(schema3, "tiledb_array_schema"))
expect_equal(schema, schema3)
}
## access schema from uri
schema2 <- schema(tmp)
expect_true(is(schema2, "tiledb_array_schema"))
expect_equal(schema, schema2)

## access schema from array
schema3 <- schema(arr)
expect_true(is(schema3, "tiledb_array_schema"))
expect_equal(schema, schema3)

## time travel
tmp <- tempfile()
Expand Down