Support strings_as_factors option#367
Merged
eddelbuettel merged 2 commits intomasterfrom Feb 16, 2022
Merged
Conversation
|
This pull request has been linked to Shortcut Story #14685: Support strings_as_factors for character columns. |
aaronwolen
approved these changes
Feb 16, 2022
| timestamp_end = as.POSIXct(double(), origin="1970-01-01"), | ||
| return_as = get_return_as_preference(), | ||
| query_statistics = FALSE, | ||
| strings_as_factors = getOption("stringsAsFactors", FALSE), |
Member
There was a problem hiding this comment.
Smart to use the global option here!
Contributor
Author
There was a problem hiding this comment.
Thanks 😀 It's a not-uncommon pattern I picked up 'somewhere' along the way; I do recall at some point a few years back Duncan Temple-Lang helped with a snippet like this. The fallback in getOption() is also golden.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional binary toggle
strings_as_factorsalong with getters and setters to permit conversion of character columns to factors.The default value is the value of the (existing base R)
option("stringsAsFactors"). A quick demonstration on the 'penguins' dataset (with a added index column) shows how the three character column are converted which makes for examplesummary()for informative for counts: