Update and extend support for memory limits and iterate on partial reads#371
Merged
eddelbuettel merged 10 commits intomasterfrom Mar 1, 2022
Merged
Update and extend support for memory limits and iterate on partial reads#371eddelbuettel merged 10 commits intomasterfrom
eddelbuettel merged 10 commits intomasterfrom
Conversation
|
This pull request has been linked to Shortcut Story #15132: Support memory limit as well as incomplete queries by looping re-using existing buffers. |
aaronwolen
approved these changes
Mar 1, 2022
Member
aaronwolen
left a comment
aaronwolen
left a comment
There was a problem hiding this comment.
Awesome! I was able to read in the previously discussed array without issue! 🙏
Contributor
Author
|
BTW if you want to monitor a little how it chunks uncomment line 486 Line 486 in e89dece and remove the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates and extends the support for setting memory limits. Its use is now per column and applied in the default retrieval for
tiledb_arrayobjects. It also extends array access to loop in case of incomplete data retrievals, reusing previously allocated buffers. This, along with a bug fix in one of the buffer allocation settings, allows for easier access to large arrays.