Additional XPtr tag fallback for SEXP initialization#390
Merged
eddelbuettel merged 4 commits intomasterfrom Apr 7, 2022
Merged
Additional XPtr tag fallback for SEXP initialization#390eddelbuettel merged 4 commits intomasterfrom
eddelbuettel merged 4 commits intomasterfrom
Conversation
|
This pull request has been linked to Shortcut Story #16691: Provide XPtr tag fallback for SEXP ctor. |
ihnorton
approved these changes
Apr 7, 2022
This was referenced Apr 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for fallback constructors for the tagged
XPtrfrom #389 by ensuring we can also initialize fromSEXPsuch asR_NilValueused in fallback#definecode. We also extend the plugin a little by ensuring the TileDB header is set and apply a little bit of polish around the vignettes where the Rmd variants (used bypkgdown) are now autogenerated from the md files that are the genuine source (and this leads to a few linebreak and other whitespace changes, no content was altered apart from adding one missing html link reference).No code changes.