Update tiledb_group_member() to return the optional group member name#399
Merged
eddelbuettel merged 3 commits intomasterfrom Apr 18, 2022
Merged
Conversation
|
This pull request has been linked to Shortcut Story #16936: Retrieve group member name. |
aaronwolen
requested review from
Shelnutt2 and
eddelbuettel
and removed request for
Shelnutt2
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
tiledb_group_member()to include a group member's name if one was set or""if not.The implementation required only a small change to the underlying the c++ function that retrieves the optional group name from the
GroupMemberclass.Tests were added to verify that
tiledb_group_member()returns a 3-element character vector whether or not a member is named.