Skip to content

Support 'dictionary encoding' compression filter#404

Merged
eddelbuettel merged 2 commits intomasterfrom
de/sc-17288/dictionary_filter
Apr 29, 2022
Merged

Support 'dictionary encoding' compression filter#404
eddelbuettel merged 2 commits intomasterfrom
de/sc-17288/dictionary_filter

Conversation

@eddelbuettel
Copy link
Copy Markdown
Contributor

This PR adds support for compression filtering via the added dictionary encoding.

@eddelbuettel eddelbuettel requested a review from ihnorton April 28, 2022 15:36
@shortcut-integration
Copy link
Copy Markdown

This pull request has been linked to Shortcut Story #17288: Add wrapping for TILEDB_FILTER_DICTIONARY.

Copy link
Copy Markdown
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please add a test when you have a chance (here or follow-up).

@eddelbuettel
Copy link
Copy Markdown
Contributor Author

eddelbuettel commented Apr 29, 2022

There is a (minimal) one for all the filters to ensure they instantiate and report back:
https://github.com/TileDB-Inc/TileDB-R/blob/master/inst/tinytest/test_filter.R#L20-L36 (that is from the master branch so no encoding yet)

(Edit: URL corrected)

@eddelbuettel eddelbuettel merged commit 31e3fee into master Apr 29, 2022
@eddelbuettel eddelbuettel deleted the de/sc-17288/dictionary_filter branch April 29, 2022 22:22
@eddelbuettel eddelbuettel mentioned this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants