Minor fix for tiledb_array's attr setter#425
Merged
eddelbuettel merged 2 commits intomasterfrom Jun 9, 2022
Merged
Conversation
eddelbuettel
approved these changes
Jun 9, 2022
Contributor
eddelbuettel
left a comment
eddelbuettel
left a comment
There was a problem hiding this comment.
Nice catch and thanks for adding a test.
Contributor
|
I am going to sneak another one-line commit in here to get rid of spurious |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix for using the attr setter to specify no attributes with
NA_character_, ie:which previously would trigger
any(is.na(pm))and proceed to the stop condition. I added a check to handle the special case wherevalueis both scalar andNAso it can proceed as expected when attempting to setup a 0-attribute query.