Update valgrind test for Ubuntu 22.04#439
Merged
eddelbuettel merged 2 commits intomasterfrom Jul 6, 2022
Merged
Conversation
|
This pull request has been linked to Shortcut Story #19185: Update valgrind tests for Ubuntu 22.04. |
ihnorton
approved these changes
Jul 6, 2022
Member
ihnorton
left a comment
ihnorton
left a comment
There was a problem hiding this comment.
I would prefer to have this exclusion expire after (say) a month to poke us to investigate again... but as long as it is tracked somewhere - LGTM.
Contributor
Author
|
Can do with a date comparison as the code is (currently, in this PR, as showm) if (Sys.getenv("_RUNNING_UNDER_VALGRIND_", "FALSE") == "TRUE") exit_file("Skipping under valgrind")which we can easily augment with an |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the nightlty valgrind action to skip one test file (for query conditions). This should restore completion of the action (as it has in tests in another repo), and give us results while we look into the root cause of the failure to complete query condition tests.
No code changes.