Update valgrind test matrix and standardize tests#442
Merged
eddelbuettel merged 3 commits intomasterfrom Jul 8, 2022
Merged
Conversation
|
This pull request has been linked to Shortcut Story #19274: Update valgrind setup and tests. |
ihnorton
approved these changes
Jul 8, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly valgrind test is operational and signals the (known) leak in 2.9.* which is now fixed in 2.10.2 and later (and no longer triggered in the 2.10 release branch). This PR removes the test for 2.9.5 as 2.9.* is essentially frozen.
It also standardizes the memory budget allocation to just two test files which need it (as opposed to effectively all by setting it when the test runner is called, also removing some old setup code no longer needed with current versions of
tinytest), and a common value of 5mb. The setting is conditional on use within CI as it only appears to 'bite' in CI use on machines with their limited memory resource allocation.Lastly, it corrects a small bug in setting of default value by ensuring directory creation is rercursive. This was seen as needed when we set the value in the test runner setup script as a user-preference.