Correct treatment of character columns with missing values#454
Merged
eddelbuettel merged 3 commits intomasterfrom Aug 11, 2022
Merged
Correct treatment of character columns with missing values#454eddelbuettel merged 3 commits intomasterfrom
eddelbuettel merged 3 commits intomasterfrom
Conversation
|
This pull request has been linked to Shortcut Story #20306: fromDataFrame mishandles factors containing NA. |
awenocur
approved these changes
Aug 11, 2022
leipzig
approved these changes
Aug 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug highlighted in the referenced Shortcut issue. In short, the treatment of character columns with missing values had a small logic error which persisted for a while, and should now be addressed.
The 'in-between releases' micro version counter has been updated to .2, and the NEWS file has been updated as well.
No new code.